goon-foss/goon
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tags): collision-safe + FK-safe alnum tag merge
Some checks are pending
Backend tests / test (push) Waiting to run
Details

Browse source 
INSERT kanonicznego membershipu (DISTINCT + ON CONFLICT) + CASCADE-delete dropów
zamiast UPDATE tag_id (który walił PK gdy scena miała dwa warianty klastra).
EXISTS-guard na keep (współbieżny run/ingest mógł skasować kanoniczny → FK).
Odpalone na prodzie: 187455→176209 tagów (11246 wariantów scalonych), 361→0
realnych klastrów-duplikatów.
This commit is contained in:
goon-foss 2026-07-21 16:24:50 +02:00
parent 80ac621344
commit 8e40993c4f
1 changed files with 18 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
scripts/merge_altkey_tags.py
View file

@ -85,23 +85,29 @@ def main() -> None:
s.rollback()
return
# UWAGA: NIE robimy UPDATE tag_id (kolizja PK gdy scena ma DWA warianty tego
# samego klastra → oba UPDATE na keep = duplikat (scene_id, keep)). Zamiast tego
# DODAJEMY membership kanonicznego (DISTINCT + ON CONFLICT), a wiersze dropów
# sprzątnie CASCADE przy DELETE FROM tags. Kolizyjno-odporne.
# EXISTS-guard na keep: gdyby kanoniczny zniknął między budową _dup_map a INSERT
# (współbieżny ingest/cleanup), pomijamy zamiast walić FK violation (całość rollback).
r1 = s.execute(text("""
UPDATE scene_tags st SET tag_id = m.keep_id
FROM _dup_map m
WHERE st.tag_id = m.drop_id
AND NOT EXISTS (SELECT 1 FROM scene_tags k
WHERE k.scene_id = st.scene_id AND k.tag_id = m.keep_id)
INSERT INTO scene_tags (scene_id, tag_id)
SELECT DISTINCT st.scene_id, m.keep_id
FROM scene_tags st JOIN _dup_map m ON st.tag_id = m.drop_id
WHERE EXISTS (SELECT 1 FROM tags kt WHERE kt.id = m.keep_id)
ON CONFLICT (scene_id, tag_id) DO NOTHING
"""))
log.info("scene_tags migrated: %d", r1.rowcount)
log.info("scene_tags keep-memberships inserted: %d", r1.rowcount)
r2 = s.execute(text("""
UPDATE movie_tags mt SET tag_id = m.keep_id
FROM _dup_map m
WHERE mt.tag_id = m.drop_id
AND NOT EXISTS (SELECT 1 FROM movie_tags k
WHERE k.movie_id = mt.movie_id AND k.tag_id = m.keep_id)
INSERT INTO movie_tags (movie_id, tag_id)
SELECT DISTINCT mt.movie_id, m.keep_id
FROM movie_tags mt JOIN _dup_map m ON mt.tag_id = m.drop_id
WHERE EXISTS (SELECT 1 FROM tags kt WHERE kt.id = m.keep_id)
ON CONFLICT (movie_id, tag_id) DO NOTHING
"""))
log.info("movie_tags migrated: %d", r2.rowcount)
log.info("movie_tags keep-memberships inserted: %d", r2.rowcount)
# blacklisted_tags PK = (device_id, tag_id) → przenieś ban z dropa na kanoniczny per device.
r3 = s.execute(text("""